-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argocd-image-updater): made argocd image updater cm and secret name templated #2998
base: main
Are you sure you want to change the base?
Conversation
Hi @KyriosGN0 And it is mentioned several times inside AUI's documentation |
we have a single argocd instance but we have 3 different image updaters, i don't want them to share the same secret/cm as they supposed to be managed in argo and if three different applications will try to control the same cm it won't work |
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
05a097b
to
40db0db
Compare
@mkilchhofer i understand that you follow the upstream project, however i belive that in this case we preserve the purpose of those cm by adding the suffixes to the end of the templated name |
My only concern is that the name changes depending on the helm command our users are using (helm's release-name). E.g.:
Maybe using 3 top-level variables with a static name would fit better? Opinions, @yu-croco @jmeridth @tico24 @mbevc1 ? |
@mkilchhofer im probably missing something, what is the issue with those names being different ? the deployment will just pull the new names (with their data unchanged) |
Signed-off-by: AvivGuiser <[email protected]>
Hey @mkilchhofer is there any info I can give to expedite the decision ? |
Signed-off-by: AvivGuiser [email protected]
Checklist: